grass.jupyter: move save() to BaseSeriesMap class to reduce redundancy #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know if the default font is acceptable on both Linux and windows? |
|
There's still a problem, as we should've removed the xfail of the test save of time series map test. Part of the log: Since we should've failed, that means I've should've used the strict option of pytest. So todo @petrasovaa : remove the xfail decorator in python/grass/jupyter/tests/timeseriesmap_test.py::test_save |
wenzeslaus
previously approved these changes
Sep 25, 2024
wenzeslaus
approved these changes
Sep 25, 2024
Yes, it comes with the Pillow library |
echoix
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces TimeSeriesMap.save() and SeriesMap.save() with BaseSeriesMap.save().
As part of this, it also fixes #4375 by unifying the parameters to
save(..., font=None, ...).